Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Traefik Hub): add APICatalogItem and ManagedSubscription support #1265

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

jspdown
Copy link
Contributor

@jspdown jspdown commented Nov 26, 2024

What does this PR do?

This PR brings the new resources (CRD, RBAC, webhook) required by Traefik Hub for:

  • APICatalogItem: Defines who can see APIs in the API catalog.
  • ManagedSubscription: Declares which Application can consume which API and how much.
  • AIService: Kubernetes-like Service to interact with a text-based LLM provider

The first 2 resources replaces the now deprecated APIAccess resource. The APIAccess used to represent simultaneously what you can see and consume.

Motivation

Bring the new Traefik Hub CRDs for managing subscription and catalog entries.

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

mloiseleur
mloiseleur previously approved these changes Nov 26, 2024
@mloiseleur mloiseleur added the kind/enhancement New feature or request label Nov 26, 2024
@mloiseleur mloiseleur changed the title feat: add APICatalogItem and ManagedSubscription CRDs feat(Traefik Hub): add APICatalogItem and ManagedSubscription support Nov 26, 2024
@jspdown
Copy link
Contributor Author

jspdown commented Nov 26, 2024

@mloiseleur As discussed, I have added the AIService CRD and the support for ManagedSubscription's claims validation. I let review it one more time.

@mloiseleur mloiseleur dismissed their stale review November 26, 2024 11:12

PR updated

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@traefiker traefiker merged commit 6bfdd50 into traefik:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants