allow -> expect in several places

driver/src/lib.rs

@@ -421,7 +421,7 @@ fn rustc_args<T: AsRef<OsStr>, U: AsRef<str>, V: AsRef<Path>>(
     Ok(rustc_args)
 }
 
-#[allow(clippy::unwrap_used)]
+#[expect(clippy::unwrap_used)]
 #[cfg(test)]
 mod test {
     use super::*;

examples/experimental/derive_opportunity/src/lib.rs

@@ -73,7 +73,7 @@ declare_lint! {
 
 impl_lint_pass!(DeriveOpportunity<'_> => [DERIVE_OPPORTUNITY]);
 
-#[allow(clippy::no_mangle_with_rust_abi)]
+#[expect(clippy::no_mangle_with_rust_abi)]
 #[no_mangle]
 pub fn register_lints(sess: &Session, lint_store: &mut LintStore) {
     dylint_linting::init_config(sess);

examples/experimental/derive_opportunity/ui/main.fixed

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/experimental/derive_opportunity/ui/main.rs

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/experimental/derive_opportunity/ui_at_least_one_field/main.fixed

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/experimental/derive_opportunity/ui_at_least_one_field/main.rs

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/experimental/derive_opportunity/ui_ignore/main.fixed

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/experimental/derive_opportunity/ui_ignore/main.rs

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/experimental/missing_doc_comment_openai/src/lib.rs

@@ -131,7 +131,7 @@ impl MissingDocCommentOpenai {
 impl<'tcx> LateLintPass<'tcx> for MissingDocCommentOpenai {
     fn check_crate(&mut self, cx: &LateContext<'tcx>) {
         if std::env::var(OPENAI_API_KEY).is_err() {
-            #[allow(clippy::disallowed_methods)]
+            #[expect(clippy::disallowed_methods)]
             cx.sess().dcx().warn(format!(
                 "`missing_doc_comment_openai` suggestions are disabled because environment \
                  variable `{OPENAI_API_KEY}` is not set"

examples/experimental/missing_doc_comment_openai/src/openai.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 use serde::{Deserialize, Serialize};
 

examples/experimental/missing_doc_comment_openai/ui/main.fixed

@@ -4,7 +4,7 @@ fn main() {}
 
 /// A doc comment generated by OpenAI.
 // A comment.
-#[allow(clippy::disallowed_names)]
+#[expect(clippy::disallowed_names)]
 pub fn foo() {}
 
 /// Negative test.

examples/experimental/missing_doc_comment_openai/ui/main.rs

@@ -3,7 +3,7 @@
 fn main() {}
 
 // A comment.
-#[allow(clippy::disallowed_names)]
+#[expect(clippy::disallowed_names)]
 pub fn foo() {}
 
 /// Negative test.

examples/general/abs_home_path/src/lib.rs

@@ -143,7 +143,7 @@ fn ui() {
     if let Some(home) = home::home_dir()
         && !Path::new(env!("CARGO_MANIFEST_DIR")).starts_with(home)
     {
-        #[allow(clippy::explicit_write)]
+        #[expect(clippy::explicit_write)]
         writeln!(
             stderr(),
             "Skipping `ui` test as repository is not stored in the user's home directory"

examples/general/await_holding_span_guard/ui/main.rs

@@ -28,7 +28,7 @@ async fn bad_owned() {
     bar().await;
 }
 
-#[allow(clippy::manual_async_fn)]
+#[expect(clippy::manual_async_fn)]
 fn bad_async_block_borrowed() -> impl std::future::Future<Output = ()> + 'static {
     async move {
         let span = span!(Level::INFO, "async_block_borrowed");
@@ -43,7 +43,7 @@ async fn baz(value: usize) {
     let _ = value;
 }
 
-#[allow(unused_must_use)]
+#[expect(unused_must_use)]
 fn main() {
     good_in_scope();
     good_instrument();

examples/general/crate_wide_allow/ui/main.rs

@@ -5,8 +5,8 @@ fn main() {
 }
 
 mod inner_attribute {
-    #![allow(clippy::bool_assert_comparison)]
-    #![allow(dead_code)]
+    #![expect(clippy::bool_assert_comparison)]
+    #![expect(dead_code)]
     fn foo() {}
     fn bar() {
         assert_eq!("a".is_empty(), false);

examples/general/non_local_effect_before_error_return/ui/main.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 use std::{
     env::{var, VarError},

examples/general/non_local_effect_before_error_return/ui_public_only/main.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 use std::{
     env::{var, VarError},

examples/general/non_thread_safe_call_in_test/src/late.rs

@@ -192,8 +192,7 @@ fn is_blacklisted_function(
     path
 }
 
-#[cfg_attr(dylint_lib = "supplementary", allow(commented_code))]
-#[cfg_attr(dylint_lib = "overscoped_allow", allow(overscoped_allow))]
+#[cfg_attr(dylint_lib = "supplementary", expect(commented_code))]
 fn command_new_additional_checks(cx: &LateContext<'_>, callee: &Expr, args: &[Expr]) -> bool {
     if let [arg] = args
         && let ExprKind::Lit(lit) = arg.kind

examples/general/src/lib.rs

@@ -6,7 +6,7 @@ dylint_linting::dylint_library!();
 extern crate rustc_lint;
 extern crate rustc_session;
 
-#[allow(clippy::no_mangle_with_rust_abi)]
+#[expect(clippy::no_mangle_with_rust_abi)]
 #[no_mangle]
 pub fn register_lints(sess: &rustc_session::Session, lint_store: &mut rustc_lint::LintStore) {
     // smoelius: Please keep the following `register_lints` calls sorted by crate name.

examples/general/wrong_serialize_struct_arg/ui/main.rs

@@ -90,7 +90,7 @@ mod multiple_serialize_struct_calls {
         field: u8,
     }
     impl Struct {
-        #[allow(dead_code)]
+        #[expect(dead_code)]
         fn foo<S>(&self, first: S, second: S) -> Result<S::Ok, S::Error>
         where
             S: Serializer,
@@ -112,7 +112,7 @@ mod nested_blocks {
         field: u8,
     }
     impl Struct {
-        #[allow(dead_code)]
+        #[expect(dead_code)]
         fn foo<S>(&self, outer: S, inner: S) -> Result<S::Ok, S::Error>
         where
             S: Serializer,
@@ -137,7 +137,7 @@ mod serialize_field_with_no_preceding_serialize_struct {
         field: u8,
     }
     impl Struct {
-        #[allow(dead_code)]
+        #[expect(dead_code)]
         fn foo<S>(&self, mut state: S::SerializeStruct) -> Result<S::Ok, S::Error>
         where
             S: Serializer,
@@ -169,7 +169,7 @@ mod wrong_serialize_struct {
         field: u8,
     }
     impl Struct {
-        #[allow(dead_code)]
+        #[expect(dead_code)]
         // smoelius: Changing `T<S>` to `S` in the next line should cause a warning to be emitted.
         fn foo<S>(&self, serializer: T<S>) -> Result<S::Ok, S::Error>
         where

examples/restriction/assert_eq_arg_misordering/ui/main.fixed

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/restriction/assert_eq_arg_misordering/ui/main.rs

@@ -1,5 +1,5 @@
 // run-rustfix
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 fn main() {}
 

examples/restriction/collapsible_unwrap/ui/main.fixed

@@ -4,7 +4,7 @@ use std::fs;
 
 const PATH: &str = "Cargo.toml";
 
-#[allow(unused_variables)]
+#[expect(unused_variables)]
 fn main() {
     assert!(std::path::Path::new(PATH)
         .canonicalize()
@@ -54,7 +54,7 @@ fn main() {
     println!("{:?}", name);
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 fn mut_test() {
     let _ = fs::read_dir(".").ok().and_then(|mut read_dir| read_dir.next()).unwrap();
 }

examples/restriction/collapsible_unwrap/ui/main.rs

@@ -4,7 +4,7 @@ use std::fs;
 
 const PATH: &str = "Cargo.toml";
 
-#[allow(unused_variables)]
+#[expect(unused_variables)]
 fn main() {
     assert!(std::path::Path::new(PATH)
         .canonicalize()
@@ -71,7 +71,7 @@ fn main() {
     println!("{:?}", name);
 }
 
-#[allow(dead_code)]
+#[expect(dead_code)]
 fn mut_test() {
     let _ = fs::read_dir(".").unwrap().next().unwrap();
 }

examples/restriction/inconsistent_qualification/ui/main.rs

@@ -1,4 +1,4 @@
-#![allow(dead_code)]
+#![expect(dead_code)]
 
 use std::env::var;
 
@@ -61,7 +61,7 @@ mod trait_import {
 // is that the compiler is not returning the correct span for that path.
 #[cfg_attr(
     dylint_lib = "inconsistent_qualification",
-    allow(inconsistent_qualification)
+    expect(inconsistent_qualification)
 )]
 mod diesel {
     use diesel::table;
@@ -100,7 +100,7 @@ mod trait_path {
 }
 
 mod relative_module_path {
-    #[allow(unused_imports)]
+    #[expect(unused_imports)]
     use bar::baz;
 
     fn foo() {

examples/restriction/misleading_variable_name/ui/main.rs

@@ -1,4 +1,4 @@
-#![allow(unused)]
+#![expect(unused)]
 
 use anyhow::{Context, Result};
 use std::{

examples/restriction/question_mark_in_expression/ui/assign_op.rs

@@ -1,4 +1,4 @@
-#![allow(unused)]
+#![expect(unused)]
 
 fn main() -> Result<(), ()> {
     let mut x = 0;

examples/supplementary/commented_code/src/lib.rs

@@ -129,7 +129,7 @@ fn check_captures(
         return;
     }
 
-    #[allow(clippy::cast_possible_truncation)]
+    #[expect(clippy::cast_possible_truncation)]
     span_lint_and_help(
         cx,
         COMMENTED_CODE,

examples/supplementary/local_ref_cell/ui/main.rs

@@ -1,4 +1,4 @@
-#![allow(unused_variables)]
+#![expect(unused_variables)]
 
 use std::cell::RefCell;
 

examples/supplementary/redundant_reference/src/lib.rs

@@ -261,7 +261,7 @@ fn ui() {
     );
 }
 
-#[cfg_attr(dylint_lib = "supplementary", allow(commented_code))]
+#[cfg_attr(dylint_lib = "supplementary", expect(commented_code))]
 #[test]
 fn ui_no_lifetime_check() {
     // smoelius: For some reason, the diagnostic messages are printed in a different order on Linux

examples/supplementary/src/lib.rs

@@ -6,7 +6,7 @@ dylint_linting::dylint_library!();
 extern crate rustc_lint;
 extern crate rustc_session;
 
-#[allow(clippy::no_mangle_with_rust_abi)]
+#[expect(clippy::no_mangle_with_rust_abi)]
 #[no_mangle]
 pub fn register_lints(sess: &rustc_session::Session, lint_store: &mut rustc_lint::LintStore) {
     // smoelius: Please keep the following `register_lints` calls sorted by crate name.

examples/supplementary/unnecessary_borrow_mut/ui/main.rs

@@ -1,4 +1,4 @@
-#![allow(unused_assignments, unused_variables)]
+#![expect(unused_assignments, unused_variables)]
 
 use std::cell::RefCell;
 

examples/supplementary/unnecessary_conversion_for_trait/src/check_inherents.rs

@@ -9,7 +9,7 @@ use rustc_middle::ty::{
 };
 use rustc_span::{symbol::sym, Symbol};
 
-#[allow(clippy::too_many_lines)]
+#[expect(clippy::too_many_lines)]
 pub fn check_inherents(cx: &LateContext<'_>) {
     let into_iterator_def_id = get_trait_def_id(
         cx.tcx,