Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify symbol reference handling #727

Merged
merged 50 commits into from
Sep 20, 2024
Merged

Conversation

xlauko
Copy link
Member

@xlauko xlauko commented Sep 17, 2024

  • makes all references use FlatSymbolRefs
  • removes SSA from variable resolution
  • introduces Cell and InitCell for cleaner Var -> Alloca lowering

@xlauko xlauko force-pushed the xlauko/symbol-reference-handling branch from cb17a91 to 48e6057 Compare September 17, 2024 13:18
@Jezurko Jezurko force-pushed the xlauko/symbol-reference-handling branch from 6592e99 to 38dac20 Compare September 19, 2024 13:46
include/vast/CodeGen/ScopeContext.hpp Show resolved Hide resolved
include/vast/Conversion/Passes.td Outdated Show resolved Hide resolved
include/vast/Conversion/Passes.td Outdated Show resolved Hide resolved
include/vast/Conversion/Passes.td Outdated Show resolved Hide resolved
include/vast/Conversion/TypeConverters/TypeConverter.hpp Outdated Show resolved Hide resolved
@xlauko xlauko marked this pull request as ready for review September 20, 2024 06:58
Copy link
Contributor

Cpp-Linter Report ⚠️

Some files did not pass the configured checks!

clang-format reports: 21 file(s) not formatted
  • include/vast/CodeGen/ScopeContext.hpp
  • include/vast/Conversion/Common/Mixins.hpp
  • include/vast/Conversion/Passes.hpp
  • include/vast/Conversion/TypeConverters/HLToStd.hpp
  • include/vast/Conversion/TypeConverters/TypeConverter.hpp
  • include/vast/Conversion/TypeConverters/TypeConvertingPattern.hpp
  • include/vast/Dialect/Core/CoreTraits.hpp
  • include/vast/Dialect/HighLevel/HighLevelOps.hpp
  • include/vast/Util/Scopes.hpp
  • lib/vast/CodeGen/CodeGenFunction.cpp
  • lib/vast/CodeGen/DefaultDeclVisitor.cpp
  • lib/vast/Conversion/FromHL/Passes.cpp
  • lib/vast/Conversion/Generic/LowerValueCategories.cpp
  • lib/vast/Conversion/ToMem/RefsToSSA.cpp
  • lib/vast/Conversion/ToMem/StripParamLValues.cpp
  • lib/vast/Conversion/ToMem/VarsToCells.cpp
  • lib/vast/Dialect/HighLevel/HighLevelOps.cpp
  • lib/vast/Dialect/HighLevel/HighLevelTypes.cpp
  • lib/vast/Dialect/HighLevel/HighLevelVar.cpp
  • lib/vast/Dialect/HighLevel/Transforms/LowerElaboratedTypes.cpp
  • lib/vast/Dialect/HighLevel/Transforms/SpliceTrailingScopes.cpp
clang-tidy reports: 1 concern(s)
  • include/vast/Dialect/Core/Interfaces/SymbolInterface.hpp:25:10: error: [clang-diagnostic-error]

    'vast/Dialect/Core/Interfaces/SymbolInterface.h.inc' file not found

       25 | #include "vast/Dialect/Core/Interfaces/SymbolInterface.h.inc"
          |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Have any feedback or feature suggestions? Share it here.

@xlauko xlauko merged commit f110c61 into master Sep 20, 2024
12 checks passed
@xlauko xlauko deleted the xlauko/symbol-reference-handling branch September 20, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants