Add Docker support and upgrade failing sharp #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnnyMarnell
changed the title
|
@transitive-bullshit any thoughts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for these great repos 🙏🏻
Had a bit of trouble getting this to run on my Macs, and I think adding Docker support can help to reduce variables with errors and troubleshooting (e.g. node-gyp failures, differing dependency versions, differing architectures). Plus this could help CI/CD, or simple case of not wanting to install Node.JS dependencies and ffmpeg itself.
Also discovered sharp dependency needed to be upgraded (breaking on multiple versions of node + arch's), see here
Tested with Docker v20.10.11, OS X Monterey, M1 / arm64, and Docker v19.03.13, OS X Catalina, Intel