improve optiga communication reliability #3303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TychoVrahe
commented
Sep 26, 2023
TychoVrahe
commented
- adds delays to physical layer
- resets the optiga via pin during initialization
matejcik
reviewed
Sep 26, 2023
matejcik
reviewed
Sep 26, 2023
core/embed/firmware/main.c
Outdated
| @@ -300,6 +300,10 @@ void SVC_C_Handler(uint32_t *stack) { | |||
| // raising privileges. | |||
| stack[6] = (uintptr_t)reboot_to_bootloader; | |||
| return; | |||
| case SVC_GET_SYSTICK_VAL: { | |||
| uint32_t *ret_ptr = (uint32_t *)stack[0]; | |||
There was a problem hiding this comment.
this looks insecure? allows unprivileged code to write to any address.
maybe we could return the value in some register or something?
There was a problem hiding this comment.
@hiviah any quick ideas how to do that?
There was a problem hiding this comment.
(alternately just reserve a static uint32_t at a known location and the caller will need to take the systick val out of there?)
There was a problem hiding this comment.
going with the static idea: 8f7ae53
[no changelog]
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/optiga/i2cfix
branch
from
8f7ae53 to
750dc50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.