Swap max_gas_fee and max_priority_fee in eip1559 fixtures
#3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marekrjpolak
force-pushed
the
test/eip-1559-fix
branch
from
d39c30d to
88b781b
Compare
marekrjpolak
force-pushed
the
test/eip-1559-fix
branch
2 times, most recently
from
88b781b to
d439350
Compare
marekrjpolak
force-pushed
the
test/eip-1559-fix
branch
from
d439350 to
49bf20b
Compare
matejcik
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running newly added EIP-1559 serialization in Connect e2e tests, I'm getting
maxFeePerGas cannot be less than maxPriorityFeePerGas (The total must be the larger of the two).I assume it's a general rule for these values so I swapped them in fixtures and regenerated the signatures.
Resubmitted trezor/trezor-common#338