New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft] THP #4050

Draft

M1nd3r wants to merge 57 commits into main from M1nd3r/thp

Contributor

M1nd3r commented Jul 22, 2024

No description provided.

M1nd3r requested a review from onvej-sl

July 22, 2024 11:42

github-actions bot commented Jul 22, 2024 •

edited

Loading

core UI changes	device test	click test	persistence test
T2T1 Model T	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3B1 Safe 3	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
T3T1 Safe 5	test(screens) main(screens)	test(screens) main(screens)	test(screens) main(screens)
All	main(screens)

M1nd3r self-assigned this

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/crypto.py Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/received_message_handler.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/cpace.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/pairing_context.py Outdated Show resolved Hide resolved

onvej-sl reviewed

View reviewed changes

core/src/trezor/wire/thp/channel.py Outdated Show resolved Hide resolved

Contributor

onvej-sl commented Jul 26, 2024

Well done, @M1nd3r !

I reviewed the usage of cryptography and compliance with our documentation of the secure channel layer.

M1nd3r force-pushed the M1nd3r/thp branch from e402934 to 98c4f11 Compare

October 10, 2024 10:44

github-actions bot commented Oct 10, 2024 •

edited

Loading

legacy UI changes	device test(screens) main(screens)

M1nd3r changed the title ~~[draft] Review of cryptography in the new THP~~ [draft] THP

M1nd3r force-pushed the M1nd3r/thp branch 11 times, most recently from db0881c to 641611b Compare

November 19, 2024 19:24

M1nd3r force-pushed the M1nd3r/thp branch from 641611b to 39062a7 Compare

November 20, 2024 14:26

M1nd3r added 29 commits

December 20, 2024 15:07


          fixup! build(ci): add thp builds and tests

74dbf3e


          fixup! feat(core): implement THP

6625bbd


          feat(python): add lock() to TrezorClientDebugLink

d08e61e

[no changelog]


          chore: update fixtures for T2T1

f4a9b3d


          fix(tests): unlock device when getting a new session

8c05e2e

[no changelog]


          chore(tests): start screen recording only after the session fixture h…

1435d09

…as a session prepared

[no changelog]


          fixup! chore: update fixtures for T2T1

fe22618


          fixup! fixup! chore: update fixtures for T2T1

9c04888

wip

cdb96f4


          wip - change session behavior

0c353eb

[no changelog]


          fixup! wip - change session behavior [no changelog]

c0d46ac


          chore(core): make await write blocking by default, remove write_force

5a2470e

[no changelog]


          fixup! fixup! wip - change session behavior [no changelog]

d6eda55


          test: fix device test test_authorize_coinjoin

62ee3fe

[no changelog]


          wip buffer locking-

beb8b58

[no changelog]


          fix: return InvalidSessionError when trying to access cache of Seedle…

adab272

…ss session

[no changelog]


          wip: single packet decryption (not finished)

8314f89

[no changelog]


          fixup! wip: single packet decryption (not finished) [no changelog]

04f6a3e


          fixup! fixup! wip: single packet decryption (not finished) [no change…

46d1605

…log]


          chore(core): make wipe device proceed even if sending of success mess…

1d3a65f

…age fails

[no changelog]


          fixup! fixup! fixup! wip: single packet decryption (not finished) [no…

e2e811e

… changelog]


          chore(core): remove management session code from handle_ThpCreateNewS…

5a65b5b

…ession

[no changelog]


          chore(core): remove TODO comment from received_message_handler

ab7293d

[no changelog]


          chore: fix incomplete enum change

[no changelog]


          WIP: try simplify message handler, might break something

5e4ecda

[no changelog]


          fixup! fixup! fixup! fixup! wip: single packet decryption (not finish…

a92c254

…ed) [no changelog]


          fixup! fixup! fixup! fixup! fixup! wip: single packet decryption (not…

abbbbd0

… finished) [no changelog]


          fix style after rebase

8256fc8


          chore(python): add session_context to cli to handle exceptions gracef…

f749055

…ully

[no changelog]

M1nd3r force-pushed the M1nd3r/thp branch from 668ccec to f749055 Compare

December 20, 2024 14:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

onvej-sl onvej-sl left review comments

mmilata mmilata left review comments

prusnak Awaiting requested review from prusnak prusnak will be requested when the pull request is marked ready for review prusnak is a code owner

matejcik Awaiting requested review from matejcik matejcik will be requested when the pull request is marked ready for review matejcik is a code owner

andrewkozlik Awaiting requested review from andrewkozlik andrewkozlik will be requested when the pull request is marked ready for review andrewkozlik is a code owner

At least 1 approving review is required to merge this pull request.

Labels

None yet