Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(core): change display orientation labels [no changelog] #4409

Merged
merged 1 commit into from
Dec 9, 2024
Merged

chore(core): change display orientation labels [no changelog] #4409

merged 1 commit into from
Dec 9, 2024

Conversation

bieleluk
Copy link
Contributor

This PR changes labels in the "Change rotation" according to Figma.

@bieleluk bieleluk added low hanging fruit Simple, quick task. T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages labels Nov 29, 2024
@bieleluk bieleluk added this to the T3T1 milestone Nov 29, 2024
@bieleluk bieleluk self-assigned this Nov 29, 2024
@bieleluk bieleluk linked an issue Nov 29, 2024 that may be closed by this pull request
Display rotation flow #4028
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 29, 2024 •
edited
Loading

legacy UI changes device test(screens) main(screens)

@bieleluk bieleluk marked this pull request as ready for review December 2, 2024 11:30
@bieleluk bieleluk requested a review from prusnak as a code owner December 2, 2024 11:30
@bieleluk bieleluk requested a review from obrusvit December 2, 2024 11:30
@matejcik matejcik removed the request for review from prusnak December 2, 2024 14:00
obrusvit
obrusvit approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@obrusvit obrusvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Just wondering, were the non-english translations provided by someone or did you use some translator?

@bieleluk
Copy link
Contributor Author

bieleluk commented Dec 3, 2024

I used translator for that and for some languages I had to do the second iteration because the first one was too long and overflowing the screen.
Is there someone in Trezor that is able to do it properly who can I add as the reviewer?

@bieleluk bieleluk force-pushed the bieleluk/mercury-display-rotation branch from c5579ca to ecebfe9 Compare December 9, 2024 08:38
@bieleluk bieleluk force-pushed the bieleluk/mercury-display-rotation branch from ecebfe9 to 8ab4c79 Compare December 9, 2024 12:55
@bieleluk bieleluk requested a review from matejcik as a code owner December 9, 2024 12:55
@bieleluk bieleluk merged commit 6de0e5d into main Dec 9, 2024
138 of 139 checks passed
@bieleluk bieleluk deleted the bieleluk/mercury-display-rotation branch December 9, 2024 14:04
@bosomt
Copy link

bosomt commented Dec 16, 2024

QA OK

Info:

  • Suite version: desktop 25.1.0 (0b116799334cb4a05fcb59cc480deb7c4b9a63e9)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuiteDev/25.1.0 Chrome/128.0.6613.186 Electron/32.2.6 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.7 regular (revision e196413)
  • Transport: BridgeTransport 2.0.33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obrusvit obrusvit obrusvit approved these changes

@matejcik matejcik Awaiting requested review from matejcik matejcik is a code owner

Assignees

@bieleluk bieleluk

Labels
low hanging fruit Simple, quick task. T3T1 Trezor Safe 5 translations Put this label on a PR to run tests in all languages
Projects
Firmware
Status: ✅ Approved
Milestone
T3T1
Development

Successfully merging this pull request may close these issues.

Display rotation flow
3 participants
@bieleluk @bosomt @obrusvit