Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

display driver for T3W1 #4415

Merged
merged 4 commits into from
Dec 13, 2024
Merged

display driver for T3W1 #4415

merged 4 commits into from
Dec 13, 2024

Conversation

TychoVrahe
Copy link
Contributor

This PR adds display driver for T3W1.

DISC2 display driver is refactored to use (mostly) same code for driving display, to eliminate duplicated DSI/LTDC settings.

Proper deinitilization is todo.

@TychoVrahe TychoVrahe self-assigned this Dec 2, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024

legacy UI changes device test(screens) main(screens)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 2, 2024 •
edited
Loading

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

@TychoVrahe TychoVrahe marked this pull request as ready for review December 2, 2024 18:19
@TychoVrahe TychoVrahe requested a review from prusnak as a code owner December 2, 2024 18:19
@TychoVrahe TychoVrahe requested review from cepetr and removed request for prusnak December 2, 2024 18:19
cepetr
cepetr requested changes Dec 10, 2024
View reviewed changes
core/embed/io/display/fb_queue/fb_queue.c Outdated Show resolved Hide resolved
core/embed/io/display/ltdc_dsi/display_fb.c Outdated Show resolved Hide resolved
core/embed/io/display/ltdc_dsi/display_fb.c Show resolved Hide resolved
core/embed/io/display/fb_queue/fb_queue.c Outdated Show resolved Hide resolved
core/embed/io/display/ltdc_dsi/display_driver.c Outdated Show resolved Hide resolved
core/embed/io/display/ltdc_dsi/display_driver.c Outdated Show resolved Hide resolved
core/embed/io/display/ltdc_dsi/display_driver.c Outdated Show resolved Hide resolved
core/embed/io/display/ltdc_dsi/panels/lx200d2406a/lx200d2406a.c Show resolved Hide resolved
core/embed/models/D002/boards/stm32u5g9j-dk.h Show resolved Hide resolved
core/embed/io/display/ltdc_dsi/display_gfxmmu.c Outdated Show resolved Hide resolved
@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/display_driver branch from ed548c7 to 680208b Compare December 13, 2024 10:54
cepetr
cepetr requested changes Dec 13, 2024
View reviewed changes
core/embed/io/display/ltdc_dsi/display_fb.c Show resolved Hide resolved
core/embed/io/display/fb_queue/fb_queue.c Outdated Show resolved Hide resolved
cepetr
cepetr approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@cepetr cepetr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally, I tested it on T3T1 and T3W1, and everything seems to be working correctly.

@TychoVrahe TychoVrahe force-pushed the tychovrahe/T3W1/display_driver branch from 511d6b6 to 9ec3a58 Compare December 13, 2024 15:36
@TychoVrahe TychoVrahe merged commit e196413 into main Dec 13, 2024
94 checks passed
@TychoVrahe TychoVrahe deleted the tychovrahe/T3W1/display_driver branch December 13, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cepetr cepetr cepetr approved these changes

Assignees

@TychoVrahe TychoVrahe

Labels
None yet
Projects
Firmware
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TychoVrahe @cepetr