refactor usb events #4426
Open
refactor usb events #4426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TychoVrahe
force-pushed
the
tychovrahe/refactor/usb_events
branch
2 times, most recently
from
7d19ea9 to
a355c19
Compare
TychoVrahe
requested review from
cepetr
and removed request for
prusnak and
matejcik
cepetr
requested changes
Dec 9, 2024
cepetr
approved these changes
Dec 12, 2024
…tation [no changelog]
TychoVrahe
force-pushed
the
tychovrahe/refactor/usb_events
branch
from
d45da63 to
f5a0f84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors how USB events (currently configured/deconfigured) are processed.
The new system is more in line with how other events, like touch or button, are processed, and allows easier addition of more events if needed (like connected/disconnected on battery powered devices perhaps).
Builds on #4419