Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend labeling click test into device test #4433

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Conversation

bieleluk
Copy link
Contributor

@bieleluk bieleluk commented Dec 9, 2024

This PR extends an "Enable labeling" click test into a device test. The prerequisite to this change was merging the Global Layout.

@bieleluk bieleluk requested a review from obrusvit December 9, 2024 16:01
@bieleluk bieleluk self-assigned this Dec 9, 2024
@bieleluk bieleluk added the translations Put this label on a PR to run tests in all languages label Dec 9, 2024
Copy link

github-actions bot commented Dec 9, 2024

core UI changes device test click test persistence test
T2T1 Model T test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3B1 Safe 3 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
T3T1 Safe 5 test(screens) main(screens) test(screens) main(screens) test(screens) main(screens)
All main(screens)

b"",
)
def input_flow():
yield
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
yield
assert (yield).name == "whatever"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bieleluk bieleluk marked this pull request as ready for review December 12, 2024 12:31
@matejcik
Copy link
Contributor

your T3B1 tests are failing now though

@bieleluk bieleluk force-pushed the bieleluk/labeling-test branch from 563f12e to f1a8847 Compare December 12, 2024 17:05
@bieleluk bieleluk merged commit 75ee4dc into main Dec 12, 2024
138 of 139 checks passed
@bieleluk bieleluk deleted the bieleluk/labeling-test branch December 12, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Put this label on a PR to run tests in all languages
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

2 participants