Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@trezor/utils package improvements #4786

Closed
10 of 13 tasks
karliatto opened this issue Jan 21, 2022 · 3 comments · Fixed by #15856
Closed
10 of 13 tasks

@trezor/utils package improvements #4786

karliatto opened this issue Jan 21, 2022 · 3 comments · Fixed by #15856
Assignees
Labels
code Code improvements

Comments

@karliatto
Copy link
Member

karliatto commented Jan 21, 2022

With the PR #4666 we are adding new package @trezor/utils. The purpose of this issue is to track potential improvements to that package and discuss whether some utilities make sense to be moved there or not.

Potential candidates for further improvements

  • trezor-suite/packages/suite/src/utils/suite/parseUri.ts
  • trezor-suite/packages/suite/src/utils/wallet/validation.ts
  • trezor-suite/packages/suite/src/utils/wallet/promiseUtils.ts
  • trezor-suite/packages/suite/src/utils/wallet/ethUtils.ts
  • trezor-suite/packages/suite/src/utils/wallet/csvParser.ts
  • trezor-suite/packages/rollout/src/utils/version.ts chore: move version utils to @trezor/utils #4870
  • trezor-suite/packages/transport/src/utils/semver-compare.ts chore: remove semver-compare util from transport #4897
  • trezor-suite/packages/utxo-lib/src/crypto.ts
  • trezor-suite/packages/utxo-lib/src/bufferutils.ts
  • connect-explorer/src/js/components/Response.tsx
  • packages/transport/src/bridge/http.ts or parts of it to have a generic http utility
  • connect/deferred Chore: connect use createDeferred from @trezor/utils #9353
  • connect/utils
@karliatto karliatto added the code Code improvements label Jan 21, 2022
@karliatto karliatto self-assigned this Jan 21, 2022
@szymonlesisz
Copy link
Contributor

szymonlesisz commented Feb 8, 2022

typescript utilities:

  • trezor-suite/packages/suite/src/types/utils
  • trezor-suite/packages/suite-desktop-api/src/methods
  • connect/types/utils

@mroz22
Copy link
Contributor

mroz22 commented Jul 16, 2024

@karliatto could you please go through the list once again? it is now pretty outdated. we could then refactor couple of those remaining and close this issue I guess

@karliatto
Copy link
Member Author

I think most of them have been moved to @trezor/utils or @trezor/wallet-utils or @trezor/node-utils with some exception that are just used in some package and probably does not make sense to move it to a more generic utils package at least until it is not required to be use somewhere else.

I moved this last one #15856 and would I marked to resolve this issue done after that one is merged.

@github-project-automation github-project-automation bot moved this to 🤝 Needs QA in Issues Suite Dec 17, 2024
@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code improvements
Projects
Status: ✅ Approved
Development

Successfully merging a pull request may close this issue.

4 participants