Chore: resolveAfter to utils package #15856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karliatto
requested review from
mroz22,
szymonlesisz,
martykan and
marekrjpolak
as code owners
13 tasks
mroz22
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
good.
I just dont like the [fix(utils): add resolveAfter util](https://github.com/trezor/trezor-suite/pull/15856/commits/82e281741d8bbfb8e188e5e6b454ce7d57ee2832) commit message. Is it really a fix? in my opinion this is a feat of utils package or a chore of the entire monorepo
karliatto
force-pushed
the
chore/resolveAfter-to-utils-package
branch
from
2bb06d8 to
87f4193
Compare
Fair enough - I have changed the commit message to feat(utils): add resolveAfter util |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create
resolveAfterutil in@trezor/utilspackage and add tests for it.Related Issue
Resolve #4786