native send flow: review & send #12240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeKne
force-pushed
the
feat/simple-native-send-form
branch
from
a9ac15c to
69bd136
Compare
juriczech
suggested changes
May 3, 2024
Comment on lines
+55
to
+57
| const decreaseOutputId = precomposedTx?.useNativeRbf | ||
| ? precomposedForm?.setMaxOutputId | ||
| : undefined; |
There was a problem hiding this comment.
This is duplicated between here and selectTransactionReviewOutputs in suite-native/module-send/src/selectors.ts, it could be moved inside the selector
| } = form; | ||
| const rawValues = watch(); | ||
|
|
||
| useEffect(() => { |
There was a problem hiding this comment.
Why is this an effect? You could debounce even in onChange handler and could be more deterministic...
vytick
reviewed
May 6, 2024
| /> | ||
| </> | ||
| )} | ||
| {totalSpent && ( |
There was a problem hiding this comment.
fee and total spent look very similar.
If this is from final design I suggest to make a component for it. If not, just ignore this
|
Closing in favor of new PR: #12968 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Closes #10867
Closes #10868
Screenshots:
Screen.Recording.2024-05-03.at.8.08.26.mov