refactor(suite): authorize device thunk

[juriczech]

Description

d57c73f

• refactor authorizeDevice thunk to rejectWithValue rather than just silent failing so we can work with rejections and fulfillments
• delete authDevice & authFailed as they became redundant since we can now subscribe to fulfilled / rejected states of redux toolkit thunks
• tweak createThunk to accept 3 generic parameters: params, success return & error return
• fix tests to reflect above changes

fd07d05

• implement passphrase duplicate in suite-native by listening to rejection of authorizeDevice

Related Issue

Resolve #12382

Screenshots:

Zaznam.obrazovky.2024-05-17.v.14.14.57.mov

[juriczech]

QA Task: https://www.notion.so/satoshilabs/Test-device-authorization-and-passphrase-4b2cb1eef7284b84a5241914d19cff62?pvs=4
cc @trezor/qa

[socket-security]

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert	Package	Note	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
New author	npm/[email protected]	New Author: styfle Previous Author: leo	Source
Trivial Package	npm/[email protected]	Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
New author	npm/[email protected]	New Author: phated Previous Author: thlorenz	Source
Shell access	npm/[email protected]	Module: child_process Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
New author	npm/[email protected]	New Author: stevemao Previous Author: shinnn	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Trivial Package	npm/[email protected]	Location: Package overview	Source
New author	npm/[email protected]	New Author: doowb Previous Author: jonschlinkert	Source
Filesystem access	npm/@nodelib/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Trivial Package	npm/[email protected]	Location: Package overview	orphan: npm/[email protected]
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	orphan: npm/[email protected]
Uses eval	npm/[email protected]	Eval Type: eval Location: Package overview	orphan: npm/[email protected]
Trivial Package	npm/[email protected]	Location: Package overview	orphan: npm/[email protected]
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
New author	npm/[email protected]	New Author: jsdnxx Previous Author: jden	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Trivial Package	npm/[email protected]	Location: Package overview	orphan: npm/[email protected]
New author	npm/[email protected]	New Author: gar Previous Author: isaacs	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Uses eval	npm/[email protected]	Eval Type: Function Location: Package overview	Source
Floating dependency	npm/@types/[email protected]	Location: Package overview	Source
Floating dependency	npm/@types/[email protected]	Location: Package overview	Source
Floating dependency	npm/@types/[email protected]	Location: Package overview	Source
Trivial Package	npm/@swc/[email protected]	Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fsevents Location: Package overview	Source
Filesystem access	npm/[email protected]	Module: fs Location: Package overview	scripts/package.json

View full report↗︎

Next steps

What is filesystem access?

Accesses the file system, and could potentially read sensitive data.

If a package must read the file system, clarify what it will read and ensure it reads only what it claims to. If appropriate, packages can leave file system access to consumers and operate on data passed to it instead.

What is new author?

A new npm collaborator published a version of the package for the first time. New collaborators are usually benign additions to a project, but do indicate a change to the security surface area of a package.

Scrutinize new collaborator additions to packages because they now have the ability to publish code into your dependency tree. Packages should avoid frequent or unnecessary additions or changes to publishing rights.

What are trivial packages?

Packages less than 10 lines of code are easily copied into your own project and may not warrant the additional supply chain risk of an external dependency.

Removing this package as a dependency and implementing its logic will reduce supply chain risk.

What is shell access?

This module accesses the system shell. Accessing the system shell increases the risk of executing arbitrary code.

Packages should avoid accessing the shell which can reduce portability, and make it easier for malicious shell access to be introduced.

What is eval?

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

What are floating dependencies?

Package has a dependency with a floating version range. This can cause issues if the dependency publishes a new major version.

Packages should specify properly semver ranges to avoid version conflicts.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/@nodelib/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/@types/[email protected]
• @SocketSecurity ignore npm/@swc/[email protected]
• @SocketSecurity ignore npm/[email protected]
• @SocketSecurity ignore npm/[email protected]

[PeKne]

Good job with the createThunk typing, really useful!