Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(suite-desktop): bridge log for node-bridge in suite-desktop #12476

Merged
merged 3 commits into from
May 24, 2024

Conversation

mroz22
Copy link
Contributor

@mroz22 mroz22 commented May 20, 2024

bridge when run by the suite-desktop app in production doesn't really log anything in the current implementation, as pointed out in #12395

  • 71dcd09 gives desktop logger an option to save logs in memory only.
  • 0fe541f
    • implements the previous commit for the bridge logger which always saves logs to its memory while keeping all other configuration as it was.
    • this commit also adds a utility function to create a facade over ILogger instance and return shape matching with Log. This allows removing some code doing the same thing on multiple places (http-receiver, node-bride server).

fixes #12395

@mroz22 mroz22 force-pushed the suite-desktop-bridge-log branch from 1b27cd1 to 7891810 Compare May 21, 2024 17:12
@mroz22 mroz22 force-pushed the suite-desktop-bridge-log branch from 7891810 to 12d66eb Compare May 22, 2024 07:21
@mroz22 mroz22 force-pushed the suite-desktop-bridge-log branch from 12d66eb to 0fe541f Compare May 22, 2024 07:30
@mroz22 mroz22 marked this pull request as ready for review May 22, 2024 07:40
@mroz22 mroz22 requested a review from karliatto as a code owner May 22, 2024 07:40
@mroz22 mroz22 changed the title wip(suite-desktop): bridge log for node-bridge in suite-desktop chore(suite-desktop): bridge log for node-bridge in suite-desktop May 23, 2024
export const convertILoggerToLog = (
iLogger: ILogger,
{ serviceName }: { serviceName: string },
): Log => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: inline

@mroz22 mroz22 merged commit 738f054 into develop May 24, 2024
25 checks passed
@mroz22 mroz22 deleted the suite-desktop-bridge-log branch May 24, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing logs in node bridge
3 participants