Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): fix EAS builds #15973

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Conversation

matejkriz
Copy link
Member

@matejkriz matejkriz commented Dec 16, 2024

Description

To be honest I don't understand why @trezor/suite-desktop-api is needed in the EAS build, but locally this fixes the issue.

- #14690 introduced dependency on @trezor/suite-desktop-api in @suite-common/connect-init
- The ultimate solution would be to split that logic to a new package and remove the dependency on desktop-api from connect-init
@matejkriz matejkriz added the mobile Suite Lite issues and PRs label Dec 16, 2024
@matejkriz
Copy link
Member Author

closing in favor of #15975

@matejkriz matejkriz closed this Dec 16, 2024
@matejkriz matejkriz reopened this Dec 17, 2024
@matejkriz matejkriz changed the title chore(ci): temporary workaround to fix EAS builds chore(ci): fix EAS builds Dec 17, 2024
@matejkriz matejkriz merged commit a2d3765 into develop Dec 17, 2024
48 of 50 checks passed
@matejkriz matejkriz deleted the fix/native/dependece-on-desktop-api branch December 17, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants