Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate t3t1 create wallet test #16147

Merged
merged 3 commits into from
Jan 3, 2025
Merged

Conversation

HajekOndrej
Copy link
Contributor

Description

Related Issue

Resolve

Screenshots:

@HajekOndrej HajekOndrej requested a review from Vere-Grey January 3, 2025 07:31
@HajekOndrej HajekOndrej force-pushed the migrate-t3t1-create-wallet-test branch 5 times, most recently from 665f712 to 0c23b30 Compare January 3, 2025 15:39
Copy link
Contributor

@Vere-Grey Vere-Grey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. I suggest:

  • one refactoring
  • DRYing one method
  • remove forgotten pause

and have question about one wait

@HajekOndrej HajekOndrej force-pushed the migrate-t3t1-create-wallet-test branch from 0c23b30 to 2d65ceb Compare January 3, 2025 17:26
@HajekOndrej HajekOndrej force-pushed the migrate-t3t1-create-wallet-test branch from 2d65ceb to 293e8ab Compare January 3, 2025 18:11
@HajekOndrej HajekOndrej force-pushed the migrate-t3t1-create-wallet-test branch from 293e8ab to ff16f73 Compare January 3, 2025 18:16
@HajekOndrej HajekOndrej requested a review from Vere-Grey January 3, 2025 18:22
Copy link
Contributor

@Vere-Grey Vere-Grey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@HajekOndrej HajekOndrej merged commit ddcbfc6 into develop Jan 3, 2025
24 checks passed
@HajekOndrej HajekOndrej deleted the migrate-t3t1-create-wallet-test branch January 3, 2025 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants