Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(suite): scroll subpage navigation on mobile #16155

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

enjojoy
Copy link
Contributor

@enjojoy enjojoy commented Jan 3, 2025

Description

Make subpage navigation scrollable

Screenshots:

Screen.Recording.2025-01-03.at.16.17.41.mov

@enjojoy enjojoy requested a review from adamhavel January 3, 2025 15:20
@enjojoy
Copy link
Contributor Author

enjojoy commented Jan 3, 2025

I was trying to add a scroll shadow there but it wasn't working right away so I decided not to spend too much time on it

@enjojoy enjojoy marked this pull request as ready for review January 3, 2025 15:24
@enjojoy enjojoy requested a review from tomasklim January 3, 2025 15:24
@enjojoy enjojoy closed this Jan 3, 2025
@enjojoy enjojoy reopened this Jan 3, 2025
@enjojoy enjojoy marked this pull request as draft January 3, 2025 15:32
@enjojoy enjojoy force-pushed the feat/account-panel-scroll branch from c6a571f to bf4ae25 Compare January 3, 2025 15:41
@enjojoy enjojoy marked this pull request as ready for review January 3, 2025 15:42
Copy link
Member

@tomasklim tomasklim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@enjojoy enjojoy merged commit 8a622eb into develop Jan 6, 2025
32 checks passed
@enjojoy enjojoy deleted the feat/account-panel-scroll branch January 6, 2025 09:03
@bosomt
Copy link
Contributor

bosomt commented Jan 7, 2025

QA OK

Info:

  • Suite version: web 25.1.0 (102be08)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/131.0.0.0 Safari/537.36
  • OS: MacIntel
  • Screen: 1512x982
  • Device: Trezor T3T1 2.8.7 regular (revision f2aeea159f1fde98d4fc5575350a8c9fc4478367)
  • Transport: WebUsbTransport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Approved
Development

Successfully merging this pull request may close these issues.

3 participants