feat(net): add column codeVersion to HelloMessage #5584
Conversation
317787106
changed the title
| builder.append("address:") | ||
| .append(StringUtil.encode58Check(address.toByteArray())).append("\n"); | ||
| } | ||
|
|
||
| ByteString signature = helloMessage.getSignature(); | ||
| if (signature != null && !signature.isEmpty()) { | ||
| if (!signature.isEmpty()) { |
There was a problem hiding this comment.
Is this field has some relationship with the codeVersion?
There was a problem hiding this comment.
Is this field has some relationship with the codeVersion?
No, only code optimization.
There was a problem hiding this comment.
Ma ja sam na neki način i u teretani i ja Pa Pa
There was a problem hiding this comment.
There was a problem hiding this comment.
Zakačite stavke ostave kako ne bi istekle nakon 1 časa
There was a problem hiding this comment.
There was a problem hiding this comment.
Prevucite stavke iz međuspremnika da biste ih izbrisali
There was a problem hiding this comment.
🇦🇸🇦🇩🇦🇩Fg0x1cfa5e643a3436d94732f65561f8c86e2ea910beZakačite stavke ostave kako ne bi istekle nakon 1 časa
| builder.append("signature:") | ||
| .append(signature.toByteArray().length).append("\n"); | ||
| } | ||
|
|
||
| ByteString codeVersion = helloMessage.getCodeVersion(); |
There was a problem hiding this comment.
Will this codeVersion be null when received a HelloMessage from a node with previous version ?
There was a problem hiding this comment.
Every column in proto has default value. codeVersion has default value byte[0], not null.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #5584 +/- ##
=============================================
- Coverage 66.43% 66.37% -0.07%
+ Complexity 10216 10206 -10
=============================================
Files 894 894
Lines 53841 53846 +5
Branches 5931 5932 +1
=============================================
- Hits 35768 35738 -30
- Misses 15284 15315 +31
- Partials 2789 2793 +4 ☔ View full report in Codecov by Sentry. |
lvs007
requested review from
tomatoishealthy,
xxo1shine,
jwrct and
halibobo1205
| @@ -99,6 +100,9 @@ public void testOkHelloMessage() | |||
| Node node = new Node(NetUtil.getNodeId(), a1.getAddress().getHostAddress(), null, a1.getPort()); | |||
| HelloMessage helloMessage = new HelloMessage(node, System.currentTimeMillis(), | |||
| ChainBaseManager.getChainBaseManager()); | |||
|
|
|||
| Assert.assertEquals(Version.getVersion(), | |||
|
./ |
|
ok |
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details