feat(net): delete config item node.discovery.bind.ip #5597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
317787106
changed the title
jwrct
reviewed
Nov 24, 2023
| PARAMETER.nodeDiscoveryBindIp = s.getLocalAddress().getHostAddress(); | ||
| } catch (IOException e) { | ||
| logger.warn("Can't get bind IP. Fall back to 127.0.0.1: " + e); | ||
| PARAMETER.nodeDiscoveryBindIp = "127.0.0.1"; |
There was a problem hiding this comment.
Why should this logic be retained?
There was a problem hiding this comment.
if the external ip is not exist, use LAN IP.
There was a problem hiding this comment.
Why hardcoded into www.baidu.com?
There was a problem hiding this comment.
@halibobo1205 It has been moved to libp2p module. This url is not necessary and we can use alternative way.
xxo1shine
approved these changes
Dec 18, 2023
jwrct
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Why are these changes required?
This PR has been tested by:
Follow up
Extra details