test(plugins/dbLite): add test for merge function #5603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #5603 +/- ##
=============================================
+ Coverage 66.30% 66.40% +0.10%
- Complexity 10193 10214 +21
=============================================
Files 894 894
Lines 53852 53852
Branches 5936 5936
=============================================
+ Hits 35709 35763 +54
+ Misses 15358 15295 -63
- Partials 2785 2794 +9 ☔ View full report in Codecov by Sentry. |
lurais
reviewed
Dec 27, 2023
| @@ -139,7 +139,7 @@ void testTools(String dbType, int checkpointVersion) | |||
| } | |||
| // start and validate the snapshot | |||
| startApp(); | |||
| generateSomeTransactions(6); | |||
| generateSomeTransactions(checkpointVersion == 1 ? 18 : 6); | |||
There was a problem hiding this comment.
Is it reasonable for the same function to produce the same input but have inconsistent actual execution logic?
There was a problem hiding this comment.
This PR is designed to test different logic.
tomatoishealthy
approved these changes
Dec 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.