Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-124262 / 24.04 / Remove haproxy from ixdiagnose #85

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

Qubad786
Copy link
Contributor

@Qubad786 Qubad786 commented Oct 2, 2023

Context

HAProxy was removed in DragonFish so there is no reason to capture it's contents in debug.

This PR removes the HAProxy related info gathering in VM plugin.

@Qubad786 Qubad786 requested a review from a team October 2, 2023 12:58
@bugclerk
Copy link

bugclerk commented Oct 2, 2023

@bugclerk bugclerk changed the title Remove haproxy from ixdiagnose NAS-124262 / 24.04 / Remove haproxy from ixdiagnose Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Merging #85 (ed02aa8) into master (ab54dac) will decrease coverage by 0.57%.
Report is 4 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   94.85%   94.29%   -0.57%     
==========================================
  Files          92       92              
  Lines        1827     1840      +13     
==========================================
+ Hits         1733     1735       +2     
- Misses         94      105      +11     
Files Coverage Δ
ixdiagnose/plugins/vm.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bmeagherix
Copy link
Contributor

I see haproxy was removed in Dragonfish in NAS-123731

However, I don't see that change being backported to 23.10, so I'm wondering why this PR has the backport-23.10 label?

@Qubad786
Copy link
Contributor Author

Qubad786 commented Oct 4, 2023

@bmeagherix thank you for pointing out - fixed the label

@yocalebo yocalebo merged commit aa26fc7 into master Oct 4, 2023
@yocalebo yocalebo deleted the NAS-124262 branch October 4, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants