Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132966 / 25.04 / Always add python3 as an explicit dependency #789

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

anodos325
Copy link
Contributor

@anodos325 anodos325 commented Dec 9, 2024

It's somewhat challenging to predict what packages may have subtle errors due to us having different python version that what is provided by upstream. This commit ensures that when we're building packages we always have our own python package present.

@anodos325 anodos325 added the WIP Work In Progress label Dec 9, 2024
@anodos325 anodos325 requested review from sonicaj and yocalebo December 9, 2024 16:25
@bugclerk bugclerk changed the title Always add python3 as an explicit dependency NAS-132966 / 25.04 / Always add python3 as an explicit dependency Dec 9, 2024
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

Copy link
Member

@sonicaj sonicaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should set batch priority for python3 in build manifest as well, LGTM otherwise

@anodos325 anodos325 removed the WIP Work In Progress label Dec 9, 2024
@anodos325 anodos325 merged commit 9480a44 into master Dec 9, 2024
3 of 4 checks passed
@anodos325 anodos325 deleted the python3-explicit-dep branch December 9, 2024 20:10
@bugclerk
Copy link
Contributor

bugclerk commented Dec 9, 2024

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Dec 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants