Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-131829 / 25.04 / Adds error log for middleware and efficient calls #11253

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

RehanY147
Copy link
Contributor

@RehanY147 RehanY147 commented Dec 29, 2024

Changes:

Adds error log for middleware. Needed for one of their tickets. Also test the steps described in the ticket. They should be fixed now.

Testing:

Code review and steps described in the ticket

@RehanY147 RehanY147 requested a review from a team as a code owner December 29, 2024 00:32
@RehanY147 RehanY147 requested review from denysbutenko and removed request for a team December 29, 2024 00:32
@bugclerk
Copy link
Contributor

@bugclerk bugclerk changed the title NAS-131829: Adds error log for middleware NAS-131829 / 25.04 / Adds error log for middleware Dec 29, 2024
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

Attention: Patch coverage is 27.27273% with 8 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (68fdc48) to head (08fd96b).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/app/store/preferences/preferences.effects.ts 0.00% 6 Missing ⚠️
.../app/pages/credentials/users/store/user.effects.ts 0.00% 1 Missing ⚠️
...pp/services/websocket/websocket-handler.service.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11253      +/-   ##
==========================================
- Coverage   82.50%   82.49%   -0.01%     
==========================================
  Files        1655     1655              
  Lines       58981    58982       +1     
  Branches     6120     6120              
==========================================
  Hits        48660    48660              
- Misses      10321    10322       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RehanY147 RehanY147 changed the title NAS-131829 / 25.04 / Adds error log for middleware NAS-131829 / 25.04 / Adds error log for middleware and efficient calls Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants