Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct typo in argument name search_duration_sec #262

Merged
merged 1 commit into from
Nov 26, 2024
Merged

fix: correct typo in argument name search_duration_sec #262

merged 1 commit into from
Nov 26, 2024

Conversation

terop
Copy link
Contributor

@terop terop commented Nov 24, 2024

No description provided.

@terop
Copy link
Contributor Author

terop commented Nov 24, 2024

@ttu this probably constitutes as a backwards incompatible API change so if possible merge this before finishing #245. I have a bunch of other PRs and I'd appreciate if you could take look at them.

@ttu ttu changed the title fix: fix a typo in an argument name of some functions fix: corrected typo in argument name search_duration_sec Nov 25, 2024
ttu
ttu requested changes Nov 25, 2024
View reviewed changes
Copy link
Owner

@ttu ttu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! This typo has been in the codebase for quite a few years 😅

CHANGELOG.md Outdated Show resolved Hide resolved
@terop terop force-pushed the fix_argument_typo branch from e11600d to c18b430 Compare November 25, 2024 17:21
@terop terop force-pushed the fix_argument_typo branch from c18b430 to 4f9988d Compare November 25, 2024 17:22
@terop terop changed the title fix: corrected typo in argument name search_duration_sec fix: correct typo in argument name search_duration_sec Nov 25, 2024
@ttu ttu merged commit 6776401 into ttu:master Nov 26, 2024
5 checks passed
@terop terop deleted the fix_argument_typo branch November 26, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttu ttu ttu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@terop @ttu