Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handler: Remove default ports in Location headers #1226

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Conversation

Acconut
Copy link
Member

@Acconut Acconut commented Dec 20, 2024

When generating an absolute URL for the Location header in POST responses, default ports (80 for HTTP and 443 for HTTPS) are now stripped. This allows users to always include the port in the X-Forwarded-Host and Forwarded headers without needing to differentiate whether the proxy listens on a default port or not.

In addition, the PR updates the Nginx configuration to include the port number in the forwarded request.

Closes #1190.

@Acconut Acconut self-assigned this Dec 20, 2024
@Acconut Acconut merged commit 571ef8d into main Dec 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant