Skip to content

Commit

Permalink
Stop using spot instances for release builds (#1760)
Browse files Browse the repository at this point in the history
We now had a failure to build release binaries due to a spot instance
getting canceled early for the second time. For now, I propose not using
a spot instance. While this will increase the cost, with it only getting
run once per release, I don't think there's cause for concern.

This change is change is already deployed to the AWS account to build
the 1.4 release artifacts.
  • Loading branch information
vkleen authored Jan 12, 2024
1 parent 0870523 commit ad00647
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions infra/spot_lambdas/start.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ def lambda_handler(event, context):
"LaunchTemplateId": launch_template_id,
"Version": "$Latest"
},
InstanceMarketOptions={
"MarketType": "spot",
"SpotOptions": {
"SpotInstanceType": "one-time",
"InstanceInterruptionBehavior": "terminate",
},
},
TagSpecifications=[
{
"ResourceType": "instance",
Expand All @@ -49,4 +42,4 @@ def lambda_handler(event, context):
'body': {
"instance_id": instance_id,
}
}
}

0 comments on commit ad00647

Please sign in to comment.