Skip to content

Commit

Permalink
Disabled default benches throughout the workspace (#2122)
Browse files Browse the repository at this point in the history
* Disabled default benches throughout the workspace

See https://bheisler.github.io/criterion.rs/book/faq.html#cargo-bench-gives-unrecognized-option-errors-for-valid-command-line-options for why this is necessary

* Replaced outdated `std.string.chars` with `std.string.characters`
  • Loading branch information
rben01 authored Dec 11, 2024
1 parent eaf676c commit bee9b82
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 4 deletions.
6 changes: 3 additions & 3 deletions core/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -112,9 +112,9 @@ harness = false
name = "arrays"
harness = false

# [[bench]]
# name = "records"
# harness = false
[[bench]]
name = "records"
harness = false

[[bench]]
name = "serialization"
Expand Down
2 changes: 1 addition & 1 deletion core/benches/records/countLetters.ncl
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
else
std.record.insert "%{char}" 1 dict
in
std.array.fold_left update_dict {} (std.string.chars s)
std.array.fold_left update_dict {} (std.string.characters s)
}
3 changes: 3 additions & 0 deletions git/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@ description = "Git utility functions for internal use in nickel"
version = "0.1.0"
edition = "2021"

[lib]
bench = false

[dependencies]
anyhow.workspace = true
gix = { workspace = true, features = ["blocking-network-client", "serde"] }
Expand Down
3 changes: 3 additions & 0 deletions lsp/lsp-harness/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ name = "lsp-harness"
version = "0.1.0"
edition = "2021"

[lib]
bench = false

[dependencies]
anyhow.workspace = true
env_logger.workspace = true
Expand Down
1 change: 1 addition & 0 deletions lsp/nls/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ version.workspace = true
[[bin]]
name = "nls"
path = "src/main.rs"
bench = false

[[bench]]
name = "main"
Expand Down
1 change: 1 addition & 0 deletions pyckel/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,4 @@ pyo3-build-config.workspace = true

[lib]
crate-type = ["cdylib", "rlib"]
bench = false
7 changes: 7 additions & 0 deletions vector/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ keywords.workspace = true
license.workspace = true
repository.workspace = true

[lib]
bench = false

[dependencies]
imbl-sized-chunks = "0.1.2"
serde.workspace = true
Expand All @@ -19,6 +22,10 @@ arbtest = "0.3.1"
criterion = "0.5.1"
rpds = "1.1.0"

[[bench]]
name = "array"
harness = false

[[bench]]
name = "rpds_comparison"
harness = false
Expand Down
1 change: 1 addition & 0 deletions wasm-repl/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,4 @@ nickel-lang-core = { workspace = true, default-features = false, features = ["re

[lib]
crate-type = ["cdylib", "rlib"]
bench = false

0 comments on commit bee9b82

Please sign in to comment.