Restore "Fix "Create profile" page not supporting dark mode (#8110)" & Fix string defaultValues during sync-metadata #9220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Changes default color scheme from 'Light' to 'System' in workspace member creation to support dark mode functionality on the 'Create profile' page.
- Modified default
colorSchemevalue in/packages/twenty-server/src/modules/workspace-member/standard-objects/workspace-member.workspace-entity.ts - Todo: Fix sync-metadata with JSON defaultValue before merging
- Impacts new user onboarding experience by respecting system color scheme preferences
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
Weiko
changed the title
Weiko
deleted the
revert-9201-revert-9185-fix/8110-new-user-dark-mode
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restoring #9185
Also fixing sync-metadata with test values in jsonb
Test
sync-metadata on existing workspaces should replace colorSchema in both metadata and workspaceMember tables