refactor(workspace): clean up resolver and improve error handling #9225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused `LoginTokenService` imports and dependencies for better code clarity. Enhanced error handling in `getPublicWorkspaceDataBySubdomain` with a try-catch block, ensuring consistent exception handling. This improves maintainability and robustness of the resolver.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Refactored workspace resolver to improve error handling and remove unused dependencies, focusing on the getPublicWorkspaceDataBySubdomain method and overall code clarity.
- Incorrect error message in
currentWorkspacemethod states "User not found" instead of "Workspace not found" in/packages/twenty-server/src/engine/core-modules/workspace/workspace.resolver.ts - Missing return statement after error handler in
updateWorkspacemethod could cause undefined responses - Error handling in
getPublicWorkspaceDataBySubdomainmay not properly propagate errors due to similar missing return - Removed unused
LoginTokenServiceimport for better code maintainability
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
packages/twenty-server/src/engine/core-modules/workspace/workspace.resolver.ts
Show resolved
Hide resolved
|
Thanks @AMoreaux for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed unused
LoginTokenServiceimports and dependencies for better code clarity. Enhanced error handling ingetPublicWorkspaceDataBySubdomainwith a try-catch block, ensuring consistent exception handling. This improves maintainability and robustness of the resolver.