Sandec fix #47
Sandec fix #47
Conversation
| fi | ||
|
|
||
| mkdir work_tmp; | ||
| cd work_tmp; |
There was a problem hiding this comment.
Here's a little bash trick for you.
TMP=$(mktemp -d)
trap "rm -rf $TMP" EXITYou'll have a temporary directory that won't collide and will automatically get cleaned up.
| @@ -0,0 +1,23 @@ | |||
| #!/bin/bash | |||
|
|
|||
There was a problem hiding this comment.
Using set -euo pipefail makes bash development a little easier and more robust.
There was a problem hiding this comment.
That's nice, didn't know about that either
| @@ -2,6 +2,7 @@ | |||
| #include <stdint.h> | |||
| #include <stdio.h> | |||
| #include <fcntl.h> | |||
| #include <unistd.h> | |||
There was a problem hiding this comment.
This is probably related to a bugfix in the compiler. Some of the calls in here, like write, are defined in unistd.h.
| if(fd2<0) | ||
| { | ||
| printf("Unable to open '%s'!\n", filename); | ||
| char cwd[512]; | ||
| getcwd(cwd, sizeof(cwd)); |
There was a problem hiding this comment.
Check the return value of getcwd. If it returns NULL then the path exceeded sizeof(cwd) with ERANGE.
|
Thanks for the review. I'll revise my commits when I get around to it... My first priority was getting the files off of that darn dictaphone and transcoded to something usable :) |
|
I totally understand! Heck, I don't even have the hardware anymore to support this project. We'll just make do as the bugs find us. :) |
Got sandec working, and added the proprietary DLL file to save other people the hassle of finding it.