Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand api metadata #96

Merged
merged 13 commits into from
Sep 23, 2023
Merged

Expand api metadata #96

merged 13 commits into from
Sep 23, 2023

Conversation

twynb
Copy link
Owner

@twynb twynb commented Sep 21, 2023

  • get more metadata from shazam
  • get more metadata from AcoustID, separate it into its own wrapper

issues/TODOs that should be added as a consequence of this:

  • a "collapse" button in ProjectItem.vue that lets users toggle between only showing core metadata (song, artist, album, duration) and extended metadata (everything)
  • the ability to scroll in the metadata select modal dropdown - this wasn't a problem before because we didn't have many results, and it's only rarely a problem now, but seeing as we can now get quite a lot of sets of metadata from AcoustID it can be possible for some of them to be out of view in the dropdown, so you can't access them as you can't scroll.

@twynb twynb self-assigned this Sep 21, 2023
@twynb twynb linked an issue Sep 21, 2023 that may be closed by this pull request
README.MD Outdated Show resolved Hide resolved
@twynb twynb requested a review from chubetho September 21, 2023 18:26
@chubetho
Copy link
Collaborator

Can you fix merge conflicts?
I have tried with hiphop.mp3 but recieved only one metadata. which test file should i try to see whether there are more metadata to come

@twynb
Copy link
Owner Author

twynb commented Sep 22, 2023

I have tried with hiphop.mp3 but recieved only one metadata. which test file should i try to see whether there are more metadata to come

What do you mean by "received only one metadata"?

If you mean "only one set of metadata per song", you might be using an invalid AcoustID key (see what i mentioned in the README.md). The Shazam service will still only return one song, so only one set of metadata, AcoustID will return a lot of songs letting you choose between options. This also means that for songs that AcoustID couldn't identify, only one set of metadata is made available (as seen when splitting the hiphop test file using the "normal" preset - the third song can't be identified by AcoustID and thus calls shazam)

If you mean only one song was identified at all, that's indeed an issue - I can't reproduce it though, for me all four songs are identified and three of them have several sets of metadata. I mostly tested using the old_pop testfile, which returns a lot of metadata options for each song.

Copy link
Collaborator

@chubetho chubetho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only added some styles to table to make it not look wierd in small screen.

@chubetho
Copy link
Collaborator

I have tried with hiphop.mp3 but recieved only one metadata. which test file should i try to see whether there are more metadata to come

What do you mean by "received only one metadata"?

If you mean "only one set of metadata per song", you might be using an invalid AcoustID key (see what i mentioned in the README.md). The Shazam service will still only return one song, so only one set of metadata, AcoustID will return a lot of songs letting you choose between options. This also means that for songs that AcoustID couldn't identify, only one set of metadata is made available (as seen when splitting the hiphop test file using the "normal" preset - the third song can't be identified by AcoustID and thus calls shazam)

If you mean only one song was identified at all, that's indeed an issue - I can't reproduce it though, for me all four songs are identified and three of them have several sets of metadata. I mostly tested using the old_pop testfile, which returns a lot of metadata options for each song.

My bad, have tried with other key and now I recieved more set of metadata for each segment

@twynb twynb merged commit 8a17626 into main Sep 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get more metadata from APIs
2 participants