Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for host-local endpoints #252

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

fundthmcalculus
Copy link
Contributor

@fundthmcalculus fundthmcalculus commented Jan 17, 2023

Objective

  • Allow services running on locahost to be mapped via their cluster routes http://servicename:serviceport vs localhost:port so that a dedicated local configuration is not required
  • Argument example: kubefwed svc -n dev --host-local runlocal-service

Process

  • Added command line flag --host-local (explicitly not localhost to reduce confusion) which allows the user to specify which services are being run locally
  • For the host-local services, the IP is forced to 127.0.0.1 (localhost) explicitly, port mapping doesn't apply.
  • The listener is disabled for these ports to prevent port reservation conflicts with the local service.
  • Addressed a couple random spelling & punctuation comments.

Open Questions

  • Should this support local port mapping via the -r 8443:443 flag?
  • Should this ignore the Dial test because the locally running service listening on the port is fine?
  • Should this support the configuration file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant