fix(network): drop the [2,…]
message tag wrapper from the rejection reason
#548
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug
Currently, the rejection reason is always prefixed with
8202
, because the entired.input()
is copied there. Andd.input()
always contains the whole input.An (incorrect) example of a
FeeTooSmallUTxO
error:This is not correct, because the first 2 bytes representing
[2, …]
are just a tag forMessage::RejectTx
, which we already give to the user, so the information is currently encoded twice.The above example should have started on line 3 (3rd byte).
The fix
We need to:
offset
d.input()
inRejectReason
by the currentd.position()
,I've also moved
d.set_position(_)
– it's the cleanest to have it in the decoder forRejectReason
, so that it behaves like other well-formed decoders, i.e. increments the current.pos
.