Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scala version 2.13 #3320

Closed
wants to merge 2 commits into from
Closed

Scala version 2.13 #3320

wants to merge 2 commits into from

Conversation

barambani
Copy link
Contributor

I've noticed that the project's scala version is still 2.12. I'm not sure if there's a reason for that. If it's not just an overlook I'm happy to close this PR.

@codecov-io
Copy link

Codecov Report

Merging #3320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3320   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files         378      378           
  Lines        7684     7684           
  Branches      233      206   -27     
=======================================
  Hits         7170     7170           
  Misses        514      514
Flag Coverage Δ
#scala_version_212 93.38% <ø> (ø) ⬆️
#scala_version_213 93.09% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e12f4d...a5cd951. Read the comment docs.

@travisbrown
Copy link
Contributor

@barambani I think there are two reasons we haven't changed these defaults yet (or at least why I haven't—others might have other reasons):

  • IIRC we'd have to roll back to 2.13.0 for the docs to build on 2.13. I can't remember the details, and it hasn't seemed important enough to spend time investigating.
  • Presumably stuff is a little more likely to break on 2.12, so if I want to quickly make sure I haven't broken anything, having e.g. validateBC run for 2.12 by default seems reasonable.

I'd be happy to move to 2.13 as default if we can resolve the first issue without rolling back to 2.13.0, though.

@barambani
Copy link
Contributor Author

Yes I realised from the ci that the issue might be this tpolecat/tut#263, and also the other you mention makes sense.
I'm closing this for a better time, as the ticket implies the solution is moving to mdoc.

@barambani barambani closed this Feb 26, 2020
@barambani barambani deleted the project-scala-version branch June 13, 2020 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants