-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split methods for HikariTransactor constructed with two effects #1961
Conversation
Partially revert the change in #1939 so that existing code don't fail to compile. Methods which construct HikariTransactor in a different effect now has the suffix "...SeparateEffect". The original single-effect methods are now implemented in terms of the separate-effect methods.
@satorg @sideeffffect Feedback welcome especially the name..it's a bit long 😅 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe ...Generic
instead of ...SeparateEffect
, because that's veeery long?
Or maybe |
@jatcwang thank you for taking on it! I personally don't have a strict preference on the naming. But I totally realize that such a name could look cryptic and for me personally any of the suggested names above will work just as well. |
For this case I don't mind it being a bit longer since it's often only written once in an application. I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this merged
Thanks all. |
Partially revert the change in #1939 so that existing code don't fail to compile. Methods which construct HikariTransactor in a different effect now has the suffix "...SeparateEffect". The original single-effect methods are now implemented in terms of the separate-effect methods.
Related: #1939