Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some more playlist item issues #2809

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Fix some more playlist item issues #2809

merged 2 commits into from
Dec 19, 2023

Conversation

goto-bus-stop
Copy link
Member

  • Newly added items were not merged (have to be consistent before we can do TS-followup: Remove the media item merging #2769)
  • Adding items to a playlist that didn't yet have a local items array would create a new array with only the new items, so the size would be wrong. Now insertions use the selector function to get the items, which prepares a correctly sized array if one isn't there.

@goto-bus-stop goto-bus-stop marked this pull request as ready for review December 19, 2023 17:38
@goto-bus-stop goto-bus-stop merged commit cac7482 into default Dec 19, 2023
10 checks passed
@goto-bus-stop goto-bus-stop deleted the new-playlist-item branch December 19, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant