upload branch for auth #73
Conversation
| @@ -20,10 +22,11 @@ const Login: React.FC = () => { | |||
| }); | |||
| } | |||
|
|
|||
| function handleLogin(e: FormEvent<Element>): void { | |||
| async function handleLogin(e: FormEvent<Element>): Promise<void> { | |||
There was a problem hiding this comment.
Can we turn this into a functional component just to match the rest of the repo 😄 ?
| domain={process.env.NEXT_PUBLIC_DOMAIN || ""} | ||
| clientId={process.env.NEXT_PUBLIC_CLIENTID || ""} |
There was a problem hiding this comment.
Do these variables come from your .env file or are they just nextjs environment variables that we can just use? If its the former, why is it different from .env.example?
I'm mostly curious cause when I'm working on CI/CD right now so its important I know all the env variables that we use.
| ) : ( | ||
| <AuthStatus /> | ||
| {isAuthenticated ? ( | ||
| <div className="grid h-full grid-cols-9 gap-1"> |
There was a problem hiding this comment.
Getting to the point where this file is a bit bloated... we should consider factoring out the lounge home page as a component and the not logged in page as its own page (in case we ever decide to add more features to that page) and move them to separate files. This probably should've been done earlier but I think the more minimal page.tsx is the better
I'll create a follow-up issue for this
hi! steps for this:
npm iinside of theclientrepoclientrepo, with values provided in Discord (can also be found in Auth0 account). Refer to.env.exampleto see what values are needed