Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transcriptions Endpoint - Flask to Node connection #15

Merged
merged 4 commits into from
Nov 30, 2024

Conversation

tdanielles
Copy link
Contributor

@tdanielles tdanielles commented Nov 28, 2024

Tasks finished

  • Integrate Flask api endpoint with the node backend by creating a ‘/transcriptions’ endpoint on node

Info and Considerations

  • Route is currently /api/transcriptions implemented in transcriptionRoutes.js
  • I tested with curl -X POST -H "Authorization: Bearer <SUPABASE-ANON-KEY>" -F "image=@assets/Filled_Logbook_page-0001.jpg" http://localhost:8080/api/transcriptions
  • Might have accidentally made formatting changes to other parts of code due to automatic formatting by Prettier but let me know if it's better for it to be reverted

@tdanielles tdanielles marked this pull request as ready for review November 28, 2024 05:08
Copy link
Contributor

@TonyLiu0226 TonyLiu0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work on integrating the transcription endpoint. Addressing comments from earlier, I think it would be best to make it a seperate route instead of adding this to logRoutes. Makes things cleaner as well as seperating the transcription logic from the endpoints to retrieve logbook data from database. I think doing it this way also shouldn't conflict with #14.

backend/src/routes/logRoutes.js Show resolved Hide resolved
@tdanielles tdanielles merged commit 1e50c61 into main Nov 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants