-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manual Entry Page #18
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work with the styling and implementation! Currently only suggesting some minor changes with respect to input types of certain fields. Let me know if you have any other questions or suggestions, otherwise once that's done feel free to merge in
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the fields, please ensure and verify the types:
caseNo
andpatientId
should be numericsocialEtOH
,Drugs
,Smoking
are currently booleans on the database and logbook template, but please feel free to double check this with designers as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a document that lists all of the current field types? According to the Figma design, caseNo
and patientId
are text fields. 😅 Same for social EtOH
, Drugs
, and Smoking
. I can update these fields if what you listed is how the database is set up!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently the database is set up that way. However, giving it a second look, I am realizing that some of the database field types may need to be changed to reflect some aspects of the figma design and stakeholder requirements, so I'd say for now we can leave as is until we confirm for sure whether the database or the figma needs changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For numeric fields, would it be possible to limit it so that the user cannot select negative numbers (specifically weight, height, and bmi.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good! sorry for the slight confusion about the database fields
PR Information
The PR implements:
Visuals
Vite.+.React.-.Google.Chrome.2024-12-01.03-26-46.mp4
Note: This PR only includes the UI portion of these pages/modals. Connecting the UI to the backend will need to be done in a separate PR. Drag and drop functionality and sticky headers will also be implemented in a separate PR.