Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual Entry Page #18

Merged
merged 18 commits into from
Dec 6, 2024
Merged

Manual Entry Page #18

merged 18 commits into from
Dec 6, 2024

Conversation

MelanieKent
Copy link
Contributor

@MelanieKent MelanieKent commented Nov 30, 2024

PR Information

The PR implements:

  • Manual Entry page
  • Create New Log modal
  • Cancel without Saving modal
  • Save to Log History modal

Visuals

Vite.+.React.-.Google.Chrome.2024-12-01.03-26-46.mp4

Note: This PR only includes the UI portion of these pages/modals. Connecting the UI to the backend will need to be done in a separate PR. Drag and drop functionality and sticky headers will also be implemented in a separate PR.

@MelanieKent MelanieKent marked this pull request as ready for review December 1, 2024 10:16
Copy link
Contributor

@TonyLiu0226 TonyLiu0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work with the styling and implementation! Currently only suggesting some minor changes with respect to input types of certain fields. Let me know if you have any other questions or suggestions, otherwise once that's done feel free to merge in

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the fields, please ensure and verify the types:

  • caseNo and patientId should be numeric
  • socialEtOH, Drugs, Smoking are currently booleans on the database and logbook template, but please feel free to double check this with designers as well

Copy link
Contributor Author

@MelanieKent MelanieKent Dec 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a document that lists all of the current field types? According to the Figma design, caseNo and patientId are text fields. 😅 Same for social EtOH, Drugs, and Smoking . I can update these fields if what you listed is how the database is set up!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
image
Currently the database is set up that way. However, giving it a second look, I am realizing that some of the database field types may need to be changed to reflect some aspects of the figma design and stakeholder requirements, so I'd say for now we can leave as is until we confirm for sure whether the database or the figma needs changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For numeric fields, would it be possible to limit it so that the user cannot select negative numbers (specifically weight, height, and bmi.)

Copy link
Contributor

@TonyLiu0226 TonyLiu0226 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! sorry for the slight confusion about the database fields

@MelanieKent MelanieKent merged commit cf9508e into main Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants