Urgent component #104
Open
Urgent component #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 3, 2023 01:02
…s and answers to render wihtout change from user
Harin329
requested changes
Apr 9, 2023
| @@ -63,6 +63,7 @@ function SingleSelect({ question }) { | |||
| question: option, | |||
| }, | |||
| }); | |||
| console.log(option) | |||
| @@ -3,10 +3,11 @@ import { useDispatch, useSelector } from "react-redux"; | |||
| import { Navigate } from "react-router-dom"; | |||
| import "./request-form.css"; | |||
| import { appColor } from "../../constants"; | |||
| import { LOAD_QUESTION } from "../../redux/actions/questionActions"; | |||
| import { LOAD_QUESTION} from "../../redux/actions/questionActions"; | |||
There was a problem hiding this comment.
lint: should have space after LOAD_QUESTION
| @@ -109,7 +120,7 @@ function RequestForm() { | |||
| billableList.push({ | |||
| service: service, | |||
| quantity: quantity, | |||
| cost: cost * quantity, | |||
| cost: isUrgent? cost * quantity * urgentMultiplier : cost * quantity, | |||
There was a problem hiding this comment.
Suggested change
| cost: isUrgent? cost * quantity * urgentMultiplier : cost * quantity, | |
| cost: isUrgent ? cost * quantity * urgentMultiplier : cost * quantity, |
| question: option, | ||
| }, | ||
| }); | ||
| console.log(option) |
| question_type: 'urgent', | ||
| question: 'Is this request urgent?', | ||
| answer_id: uuid(), | ||
| answer: "No"}); |
There was a problem hiding this comment.
We should probably use true or false here, but I think the answer is text typed, if that's the case, we should probably modify how we check the answer below.
| return ( | ||
| <div className="single-select-option" key={index}> | ||
| <FormControlLabel | ||
| value={option.answer} |
There was a problem hiding this comment.
this option.answer is likely a "yes" "No" string in your implementation, so it will always be true, maybe we should have it check whether it is "Yes" or "No"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created a new question type "Urgent" where the total cost will be multiplied by a given multiplier (currently 1.5x) if the urgent question is selected "yes".
Screen.Recording.2023-03-31.at.2.06.27.AM.mov
Currently, there are some weird small issues with the costs that are displayed sometimes. Also, we may want to have an area where the user will be notified how much extra they will be charged for urgent requests.