Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix header for string-byte-slice #202

Merged
merged 5 commits into from
Nov 28, 2023
Merged

Conversation

alex-semenyuk
Copy link
Contributor

Currently "Avoid string-to-byte conversion" sounds like we should avoid it at all, but this paragraph means else

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@mway mway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alex-semenyuk, thanks! SGTM modulo minor rephrasing.

@@ -1,4 +1,4 @@
# Avoid string-to-byte conversion
# Avoid string-to-byte conversion repeatedly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think this reads slightly better:

Avoid repeated string-to-byte conversions

Copy link
Contributor

@mway mway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@mway mway merged commit 09114fa into uber-go:master Nov 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants