Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove very old pickle compatibility code modifying old atg package names #702

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

selitvin
Copy link
Collaborator

@selitvin selitvin commented Jul 26, 2021

This is code cleanup. The code was meant to support opening some old datasets that contained pickled data with pre-petastorm names.

Can not specify selitvin:selitvin/remove_legacy as an upstream, so github shows two commits in this PR. Please review only the second commit as the first is part of #640

@selitvin selitvin requested a review from chongxiaoc July 26, 2021 04:50
@selitvin selitvin force-pushed the selitvin/remove_legacy branch 2 times, most recently from bbd0d5e to c0d5337 Compare July 26, 2021 05:39
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #702 (e54d908) into master (d32709d) will increase coverage by 0.00%.
The diff coverage is 86.66%.

@@           Coverage Diff           @@
##           master     #702   +/-   ##
=======================================
  Coverage   86.27%   86.27%           
=======================================
  Files          85       85           
  Lines        5084     5070   -14     
  Branches      787      784    -3     
=======================================
- Hits         4386     4374   -12     
+ Misses        559      558    -1     
+ Partials      139      138    -1     
Impacted Files Coverage Δ
petastorm/etl/safe_pickle.py 81.81% <81.81%> (ø)
petastorm/etl/dataset_metadata.py 87.33% <100.00%> (ø)
petastorm/etl/rowgroup_indexing.py 64.51% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32709d...e54d908. Read the comment docs.

@selitvin selitvin force-pushed the selitvin/remove_legacy branch 3 times, most recently from 0eee866 to 8ca9df8 Compare July 28, 2021 23:25
Yevgeni Litvin added 2 commits April 13, 2022 21:37
…ames

The code was meant to support opening some old datasets that contained
pickled data with pre-petastorm names.
It was removed by mistake. The test actually tests an ability to read a
dataset created with previous version of petastorm.
@selitvin selitvin force-pushed the selitvin/remove_legacy branch from 16de47f to 513533b Compare April 14, 2022 04:38
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ selitvin
❌ Yevgeni Litvin


Yevgeni Litvin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants