[PiranhaJava] Deleting statements containing specific Mockito API patterns #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ketkarameya
changed the title
mkr-plse
reviewed
Dec 1, 2021
| " when(experimentation.isToggleDisabled(\"STALE_FLAG\")).thenReturn(false);", | ||
| " when(experimentation.isToggleEnabled(\"STALE_FLAG\")).thenThrow(new RuntimeException());", | ||
| " when(experimentation.isToggleDisabled(\"STALE_FLAG\")).thenCallRealMethod();", | ||
| " when(experimentation.isToggleEnabled(\"STALE_FLAG\")).then(ans);", |
There was a problem hiding this comment.
can we also add a non stale flag in the mix?
| if (enclosingNode(MOCKITO_UNNECESSARY_MOCKING_PATTERN).matches(tree, state)) { | ||
| StatementTree stmt = ASTHelpers.findEnclosingNode(state.getPath(), StatementTree.class); | ||
| if (stmt != null) { | ||
| return buildDescription(stmt).addFix(SuggestedFix.delete(stmt)).build(); |
There was a problem hiding this comment.
can the changes happen in updateCode? If not, maybe update the startPos and endPos here?
ketkarameya
commented
Dec 1, 2021
ketkarameya
force-pushed
the
feature/specific-use-cases-104
branch
from
90e2577 to
079f33d
Compare
Fixed the Swift CI issue Addressed the issues mentioned in the PR and offline Added support for then* pattern Added delete statement logic for specific patterns menntioned in issue uber#104
ketkarameya
force-pushed
the
feature/specific-use-cases-104
branch
from
079f33d to
4ac47a7
Compare
mkr-plse
approved these changes
Dec 2, 2021
mkr-plse
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when(...).then*()pattern.