-
Notifications
You must be signed in to change notification settings - Fork 663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could you please help me check my prototype for zcu102? #2109
base: main
Are you sure you want to change the base?
Conversation
This will fixes #3.
Question 1: I can't use the newest version of FireMarshal to build the fpga prototype for my zcu102 fpga due to some zip package lost. In this issue: firesim/FireMarshal#312 I have already try much methods and can't solove it, can u give me some useful ideas? |
Can u just help me check the fpga/src/main/scala/zcu102/HarnessBinders.scala Or IOBinder.scala files about the implement of Memory, or explain how to implement them. |
Thanks, these changes overall look very good, and I'd be happy to accept them. However, the current state of the PR contains a lot of unnecessary changes and additions, making it difficult to review the critical code. If you could create a new PR that contains only the necessary changes to enable zcu102 and zcu106, I can take a closer look. |
Okay, I have organized my code and created two new PRs.
I think this pr can be closed and focus on another links. |
Related PRs / Issues:
Type of change:
Impact:
Contributor Checklist:
main
as the base branch?changelog:<topic>
label?changelog:
label?.conda-lock.yml
file if you updated the conda requirements file?Please Backport
?CI Help:
Add the following labels to modify the CI for a set of features.
Generally, a label added only affect subsequent changes to the PR (i.e. new commits, force pushing, closing/reopening).
See
ci:*
for full list of labels:ci:fpga-deploy
- Run FPGA-based E2E testingci:local-fpga-buildbitstream-deploy
- Build local FPGA bitstreams for platforms that are releasedci:disable
- Disable CI