Kayla/submissions page #415
Conversation
github-actions
bot
added
the
page
| > | ||
| Apply | ||
| </BorderLink> : | ||
| <BorderLink |
There was a problem hiding this comment.
After HOTH ends, this Submit button will show as a disabled button, which is not an issue but is that functionality you want? Imo, it might be weird to have a disabled Submit button for the rest of the year when HOTH is not running, but we can always fix that later.
| Thank You for Participating in HOTH XI! | ||
| </Typography> | ||
|
|
||
| <Typography align='left' variant='h5' component='h2'> |
There was a problem hiding this comment.
It's a little odd to have 2 lines so close to each other that have the same styling, like this. Maybe we can move the Thank you text to the bottom after the steps to submit and make it variant='h6' component='h3' or something?
|
|
||
| <Typography className={classes.info}> | ||
| 1{')'} Submit the project on the HOTH XI {' '} | ||
| <Link to='https://hoth-xi.devpost.com/?ref_feature=challenge&ref_medium=discover'>devpost</Link> |
There was a problem hiding this comment.
nit: it would be cool to have these links as hack pink (I think that's theme.palette.secondary.main) before users click on the link and then theme.palette.secondary.dark after the user has clicked on the link.
| className={devPostClicked ? classes.linkClicked : classes.link} | ||
| onClick={handleDevPostClick} | ||
| > | ||
| devpost |
There was a problem hiding this comment.
Small nit: can we capitalize "Devpost"
| className={formClicked ? classes.linkClicked : classes.link} | ||
| onClick={handleFormClick} rel="noreferrer" | ||
| > | ||
| HOTH XI Submission Form |
There was a problem hiding this comment.
Another small nit: can we add "Google" before "Form" and make it so that the link only includes "Submission Google Form"
So it would say "2) Fill out the HOTH XI Submission Google Form" with the link being for "Submission Google Form"
|
|
||
| <Typography className={classes.info}> | ||
| 1{')'} Submit the project on the HOTH XI{' '} | ||
| <a |
There was a problem hiding this comment.
Is there a specific reason we used the <a> tag here instead of MUI's <Link> tag? If not, maybe switch to <Link>
There's an example of this tag's usage in src/components/HomePage/HothDescription.js
|
|
||
| <Typography className={classes.info}> | ||
| 2{')'} Fill out the{' '} | ||
| <a |
There was a problem hiding this comment.
Switch to <Link> tag here too potentially?
Fixes #365
HOTH XI
-created submissions page with info for HOTH XI
-altered Apply button so it will change to Submit button during HOTH