Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update components/AlertInbox/Popup.tsx #306

Merged
merged 4 commits into from
Oct 13, 2023
Merged

Update components/AlertInbox/Popup.tsx #306

merged 4 commits into from
Oct 13, 2023

Conversation

lawtlee
Copy link
Contributor

@lawtlee lawtlee commented Oct 13, 2023

Added the ability to close the popup by clicking
off of it.

Updated Popup to close on clickoff

Summary

Closes #26

  • Implemented a ref in the popup div
  • Same code as used in Navbar.tsx

Screenshots

Screen.Recording.2023-10-13.at.11.44.02.AM.mov

Added the ability to close the popup by clicking
off of it.
@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for parcel-pointers ready!

Name Link
🔨 Latest commit ea84756
🔍 Latest deploy log https://app.netlify.com/sites/parcel-pointers/deploys/6529a662ad1c9f000847a20c
😎 Deploy Preview https://deploy-preview-306--parcel-pointers.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lawtlee lawtlee requested a review from Dankco October 13, 2023 18:45
Removed console.log that created a lint
error
@Dankco
Copy link
Contributor

Dankco commented Oct 13, 2023

Not sure what the linting error is here, but try running yarn lint-fix and recommiting.

It was a tab-spacing on a comment
Copy link
Contributor

@Dankco Dankco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Dankco Dankco merged commit 7e92155 into main Oct 13, 2023
5 checks passed
@Dankco Dankco deleted the 26_close_popup_patch1 branch October 13, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Update: Popup closes if user clicks off it
2 participants