Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Navigation Bar #307

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Update Navigation Bar #307

merged 3 commits into from
Oct 13, 2023

Conversation

lawtlee
Copy link
Contributor

@lawtlee lawtlee commented Oct 13, 2023

Updated the Navbar to follow the order
given by PageOrder in globalTypes.ts

Update Navbar Navigation Order

Summary

Closes #305

  • Switched two divs in order to accurately represent the order of pages given by PageOrder

Screenshots

image

Updated the Navbar to follow the order
given by PageOrder in globalTypes.ts
@lawtlee lawtlee requested review from ajtadeo and Dankco October 13, 2023 18:53
@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for parcel-pointers ready!

Name Link
🔨 Latest commit 57cef99
🔍 Latest deploy log https://app.netlify.com/sites/parcel-pointers/deploys/6529a4dd2c8ce70008c448a2
😎 Deploy Preview https://deploy-preview-307--parcel-pointers.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lawtlee lawtlee removed the request for review from ajtadeo October 13, 2023 18:53
@Dankco
Copy link
Contributor

Dankco commented Oct 13, 2023

Could you decrease the spacing here a little bit between the "Why Pointers?" and "Demo" and "Demo" and "Lessons"? Maybe more proportional to the space between Lessons and Exercises.
image

Changed the dropdown-header to flex instead of block
allowed for all headings to be centered vertically
Fixed the lint error, i didn't alphabetically
order the css
Copy link
Contributor

@Dankco Dankco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Dankco Dankco merged commit d35133c into main Oct 13, 2023
5 checks passed
@Dankco Dankco deleted the 305_Sidebar_Nav branch October 13, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Update: Update Sidebar and Navigation buttons to follow the correct order of page flows
2 participants