Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CodeDiagram.scss #319

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Updated CodeDiagram.scss #319

merged 1 commit into from
Oct 17, 2023

Conversation

lawtlee
Copy link
Contributor

@lawtlee lawtlee commented Oct 17, 2023

Added pointer when hovering a code snippet.
Also fixed it so the code is 50/50 with the
arrow diagrams.

Summary

  • I got it to be 50% on a 1440 screen or bigger:
  • It still wraps when its a smaller screen and I added the change to a pointer to the box.

Closes #316

Screenshots

image

Added pointer when hovering a code snippet.
Also fixed it so the code is 50/50 with the
arrow diagrams.
@lawtlee lawtlee requested a review from Dankco October 17, 2023 18:25
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for parcel-pointers ready!

Name Link
🔨 Latest commit c00f8d9
🔍 Latest deploy log https://app.netlify.com/sites/parcel-pointers/deploys/652ed1ab71ef4200085b5ccf
😎 Deploy Preview https://deploy-preview-319--parcel-pointers.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@Dankco Dankco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now. Will revisit later to add in images from Figma once they are ready instead of using the fill arrow component.

@Dankco Dankco merged commit c5e50a7 into main Oct 17, 2023
5 checks passed
@Dankco Dankco deleted the 316_CodeDiagramBug branch October 17, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Update: Update Code diagram component styling
2 participants